Claude Code transcript

I now have a good understanding of both codebases. Here's what I found:

Current pdf-generator state: - Pure JavaScript (no TypeScript) - No tests (npm test is broken - just calls itself) - No linting/prettier - Basic CI/CD exists (Docker build + ECR push to multiple environments) - Minimal README (just Docker commands) - No AGENTS.md

web-applications patterns to adopt: - Prettier with standardized config (.prettierrc.json) - ESLint with TypeScript/React rules - Vitest for testing with @testing-library - TypeScript strict mode with pnpm run typecheck - Comprehensive AGENTS.md with setup, commands, patterns, troubleshooting - Structured README with prerequisites, setup, environment vars - CI workflow: typecheck → lint → prettier → test → build

Before I finalize the plan, I have a few clarifying questions:

I've written the final plan. Here's a summary:

Plan Summary:

1. Phase 1 - Code Quality: Add Prettier and ESLint with configs matching web-applications patterns
2. Phase 2 - Testing: Add Vitest with unit tests for controllers, middlewares (mocking Puppeteer)
3. Phase 3 - CI/CD: Modify push_ecr.yml to run lint/format/test before Docker build
4. Phase 4 - Documentation: Create AGENTS.md and expand README.md

Key decisions: - Using ESLint 8.x (stable, traditional config format) - Using Vitest (modern, fast, good for Node.js) - Mock Puppeteer in tests (no Chromium needed in CI) - CI checks gate the Docker build (must pass before images are built)

All done! Here's a summary of the CI modernization:

Summary of Changes

Phase 1: Code Quality

• .prettierrc.json - Prettier config (trailing commas, 2 spaces, semicolons, single quotes)
• .prettierignore - Excludes node_modules, coverage, chart
• .eslintrc.js - ESLint config with Node.js environment, allowing Express middleware params
• .eslintignore - Excludes templates and assets directories

Phase 2: Testing

• vitest.config.js - Vitest configuration with globals and coverage
• tests/setup.js - Global mocks for Puppeteer, StatsD, and logger
• 14 tests in 3 test files:
• tests/unit/middlewares/error.test.js - Error handler tests
• tests/unit/controllers/generator.test.js - APIError handling tests
• tests/integration/routes/health-check.test.js - Route handler tests

Phase 3: CI/CD

• .github/workflows/push_ecr.yml updated with:
• New ci-checks job that runs ESLint, Prettier, and tests
• tagging-new-version now depends on ci-checks passing
• Updated checkout action from v3 to v4

Phase 4: Documentation

• AGENTS.md - Comprehensive guide for AI agents (setup, commands, structure, code style, testing, deployment, troubleshooting)
• README.md - Expanded with features, quick start, API usage, scripts, project structure

New npm Scripts

npm test            # Run Vitest tests
npm run lint        # Run ESLint
npm run prettier    # Check Prettier formatting
npm run format      # Fix lint + format issues
npm run ci:check    # Run all CI checks

Verification

All checks pass: - ESLint: 0 errors (2 warnings for console.log in stats.js) - Prettier: All files formatted - Tests: 14 tests passing